API: Introduce DefaultMetricsContext and Timer interface#5286
Merged
rdblue merged 1 commit intoJul 20, 2022
Conversation
nastra
commented
Jul 15, 2022
nastra
force-pushed
the
default-metrics-context-and-timer-api
branch
from
b3785e7 to
b3d3879
Compare
rdblue
requested changes
Jul 16, 2022
Contributor
rdblue
left a comment
rdblue
left a comment
There was a problem hiding this comment.
Sorry, I didn't see this until I left a lot of comments on the combined PR. Could you take a look at my review comments from that one?
nastra
force-pushed
the
default-metrics-context-and-timer-api
branch
2 times, most recently
from
1e04c03 to
7c3a67f
Compare
Contributor
Author
|
@rdblue @danielcweeks I believe I addressed all comments, can you guys re-review please? |
The idea here is that a `DefaultMetricsContext` can be used with native Java Counters/Timers to measure things. Additionally, this is introducing an API and a default implementation for a Timer, which can be used to measure execution time.
nastra
force-pushed
the
default-metrics-context-and-timer-api
branch
from
7c3a67f to
8bd148a
Compare
rdblue
approved these changes
Jul 20, 2022
Contributor
|
Looks great. Thanks for adding this, @nastra! |
singhpk234
pushed a commit
to singhpk234/iceberg
that referenced
this pull request
Jul 20, 2022
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is that a
DefaultMetricsContextcan be used with nativeJava Counters/Timers to measure things.
Additionally, this is introducing an API and a default implementation
for a Timer, which can be used to measure execution time.