API/Core: Initial Table Scan Reporting support#5268
Merged
Conversation
845ae00 to
b2fd00b
Compare
rdblue
reviewed
Jul 14, 2022
rdblue
reviewed
Jul 14, 2022
rdblue
reviewed
Jul 14, 2022
rdblue
reviewed
Jul 14, 2022
rdblue
reviewed
Jul 14, 2022
rdblue
reviewed
Jul 14, 2022
rdblue
reviewed
Jul 14, 2022
rdblue
reviewed
Jul 14, 2022
kbendick
reviewed
Jul 14, 2022
Contributor
Author
rdblue
reviewed
Jul 15, 2022
rdblue
reviewed
Jul 15, 2022
rdblue
reviewed
Jul 15, 2022
rdblue
reviewed
Jul 15, 2022
rdblue
reviewed
Jul 15, 2022
rdblue
reviewed
Jul 15, 2022
rdblue
reviewed
Jul 15, 2022
rdblue
reviewed
Jul 15, 2022
rdblue
reviewed
Jul 15, 2022
rdblue
reviewed
Jul 15, 2022
rdblue
reviewed
Jul 15, 2022
rdblue
reviewed
Jul 29, 2022
rdblue
reviewed
Jul 29, 2022
rdblue
reviewed
Aug 3, 2022
rdblue
reviewed
Aug 3, 2022
rdblue
reviewed
Aug 3, 2022
rdblue
reviewed
Aug 3, 2022
rdblue
reviewed
Aug 3, 2022
rdblue
reviewed
Aug 3, 2022
rdblue
reviewed
Aug 3, 2022
rdblue
reviewed
Aug 3, 2022
rdblue
reviewed
Aug 3, 2022
The idea here is that we collect metrics during Table scans so that we can better understand where time is spent during a scan and how many files are being looked at.
rdblue
approved these changes
Aug 3, 2022
Contributor
|
Thanks @nastra! I just merged this. |
Member
|
Just FYI, this seems to have inflated logs quite noticeably (trinodb/trino#15492). |
This was referenced Dec 21, 2022
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is that we collect metrics during Table scans so that we
can better understand what exactly happens during a Table scan.
This is just an initial implementation that gathers/records a few metrics. The idea is to get early feedback on this approach.
Overview of proposed changes
ScanReportthat contains all relevant metrics from a ScanScanReporterinterface that can be used to collect and report different metrics during a Table scant. Engines can implement this API to customize how aScanReportis being reportedLoggingScanReporteris introduced that logs aScanReportto the log file. We can think about defaulting to that one or using a no-op scan reporterscan-reporter-implis introduced, allowing a Catalog to specify whichScanReporterto useScanMetricsthat carries all relevant metrics during a Table scan. This class should be seen as something that is only used during a scan. At the end of a scan we'll want to create aScanReportbased on the collected metricsTimerand aDefaultTimerwere introduced so that we can measure spent time for a table scanDefaultScanMetricsthat use native Java Integer/Long counters and aDefaultTimer