Core: Fix wrapper performance for delete filters#5249
Merged
Conversation
Co-Authored-By: shidayang <[email protected]> Closes apache#5244.
Co-Authored-By: shidayang <[email protected]> Closes apache#5242.
aokolnychyi
approved these changes
Jul 11, 2022
Contributor
Author
|
Thanks, @aokolnychyi! |
This was referenced Jul 11, 2022
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 18, 2022
Core: Add StructLikeWrapper#copyFor to avoid type analysis. Core: Add InternalRecordWrapper#copyFor to avoid type analysis. Co-Authored-By: shidayang <[email protected]> Closes apache#5242. Closes apache#5244.
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 18, 2022
Core: Add StructLikeWrapper#copyFor to avoid type analysis. Core: Add InternalRecordWrapper#copyFor to avoid type analysis. Co-Authored-By: shidayang <[email protected]> Closes apache#5242. Closes apache#5244.
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 20, 2022
Core: Add StructLikeWrapper#copyFor to avoid type analysis. Core: Add InternalRecordWrapper#copyFor to avoid type analysis. Co-Authored-By: shidayang <[email protected]> Closes apache#5242. Closes apache#5244.
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
Core: Add StructLikeWrapper#copyFor to avoid type analysis. Core: Add InternalRecordWrapper#copyFor to avoid type analysis. Co-Authored-By: shidayang <[email protected]> Closes apache#5242. Closes apache#5244. (cherry picked from commit fa07d9f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation of #5242 and #5244. Rather than adding factory classes, this adds a
copyFormethod toStructLikeWrapperandInternalRecordWrapper. This is smaller than adding a factory and keeps the logic in one place (rather than duplicating it in a factory).This updates cases where the wrappers are used to copy wrappers rather than create new ones. This avoids analyzing the type that the wrappers are created for and should speed up execution.