Core: Include delete files in 'files' and add 'data_files' table#4336
Merged
Conversation
Member
Author
|
@aokolnychyi @rdblue @RussellSpitzer fyi when anyone has a cycle, thanks |
szehon-ho
changed the title
szehon-ho
force-pushed
the
data_file_table
branch
2 times, most recently
from
9c6b07b to
fd93320
Compare
szehon-ho
force-pushed
the
data_file_table
branch
from
fd93320 to
85573a0
Compare
Contributor
|
Let me take a look today. |
aokolnychyi
reviewed
Mar 21, 2022
aokolnychyi
reviewed
Mar 21, 2022
| } | ||
| } | ||
|
|
||
| private int expectedCount(int partitions) { |
Contributor
There was a problem hiding this comment.
nit: expected count of what?
aokolnychyi
approved these changes
Mar 21, 2022
Member
Author
|
Merged, thanks @aokolnychyi for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #4139, this is the second step after adding 'delete_files' table, to synchronize the similar metadata tables to handle the delete file concept.
In this PR:
This might be hard to split into two prs, as it's doing a hot-swap migrating the 'files' table class (called DataFilesTable) to support new table 'data_files'.