Hive: ensure unlock is called when new metadata cannot be deleted#1998
Merged
Conversation
giovannifumarola
approved these changes
Dec 28, 2020
| } | ||
| } catch (RuntimeException e) { | ||
| LOG.error("Fail to cleanup metadata file at {}", metadataLocation, e); | ||
| throw e; |
There was a problem hiding this comment.
Not a fan of Throw within a Catch.
Maybe you can wrap it in something else.
Contributor
There was a problem hiding this comment.
I think this is fine because we don't want to wrap or modify the original exception, and it is helpful to log the metadata location that was not correctly deleted.
Contributor
There was a problem hiding this comment.
I think we may leverage runSafely that was added recently.
ExceptionUtil.runSafely(
() -> {
if (errorThrown) {
// if anything went wrong, clean up the uncommitted metadata file
io().deleteFile(metadataLocation);
}
return Void.TYPE;
},
e -> LOG.error("Failed to cleanup metadata file at {}", metadataLocation, e),
() -> unlock(lockId));
Contributor
There was a problem hiding this comment.
rdblue
approved these changes
Dec 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrap
io().deleteFile(metadataLocation)in try catch block so thatunlock(lockId)must be called in the finally block.