AWS, Aliyun: Fix memory leak by removing deleteOnExit() calls#13749
Merged
stevenzwu merged 1 commit intoAug 6, 2025
Merged
Conversation
Remove unnecessary File.deleteOnExit() calls from S3OutputStream and OSSOutputStream that were causing memory leaks in long-running servers. These calls registered files in the global DeleteOnExitHook set which never gets cleared during normal operation, leading to unbounded heap growth. The explicit cleanup logic already handles temporary file deletion properly.
nastra
approved these changes
Aug 6, 2025
ebyhr
approved these changes
Aug 6, 2025
singhpk234
approved these changes
Aug 6, 2025
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM too ! Thanks @kamijin-fanta
from coverage perspective is there tests for asserting this already :
The explicit cleanup logic already handles temporary file deletion properly.
stevenzwu
approved these changes
Aug 6, 2025
Contributor
|
thanks @kamijin-fanta for the root cause analysis and the fix, and everybody for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3OutputStreamdue toFile.deleteOnExit()hook #13738Remove unnecessary
File.deleteOnExit()calls fromS3OutputStreamandOSSOutputStreamthat were causing memory leaks in long-running servers. These calls registered files in the globalDeleteOnExitHookset which never gets cleared during normal operation, leading to unbounded heap growth. The explicit cleanup logic already handles temporary file deletion properly.