Hive: Throw exception for when listing a non-existing namespace#13130
Merged
nastra merged 2 commits intoJun 3, 2025
Conversation
Contributor
|
@jmelinav: Could you please run |
nastra
reviewed
May 23, 2025
pvary
reviewed
May 26, 2025
nastra
approved these changes
May 26, 2025
stevenzwu
reviewed
Jun 2, 2025
| @Override | ||
| public List<Namespace> listNamespaces(Namespace namespace) { | ||
| if (!isValidateNamespace(namespace) && !namespace.isEmpty()) { | ||
| if (!namespace.isEmpty() && (!isValidateNamespace(namespace) || !namespaceExists(namespace))) { |
Contributor
There was a problem hiding this comment.
nit: move line 514-516 to the beginning of this method. then we can remove the namespace condition here.
Contributor
Author
There was a problem hiding this comment.
the issue is with non existing namespace, if I move the lines 514-516 to the beginning, it will always return empty list irrespective of whether namespace exists or not. (which is the current behavior).
Contributor
|
Thanks @jmelinav for the PR, and sorry for the long delay in merging! |
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throw exception for when listing a non-existing namespace
Fixes #12874