Spec, OpenAPI: Adds EnableRowLineage Metadata Update#12050
Merged
RussellSpitzer merged 3 commits intoJan 24, 2025
Conversation
flyrain
reviewed
Jan 23, 2025
| properties: | ||
| action: | ||
| type: string | ||
| const: "enable-row-lineage" |
Contributor
There was a problem hiding this comment.
I might be overthinking this, but I believe it’s worth adding a comment to clarify that disabling row lineage is not allowed by the table spec. It’s natural for people to wonder about the absence of such an option, so providing this context upfront would make things clearer.
Member
Author
There was a problem hiding this comment.
I added a comment a few lines above
danielcweeks
approved these changes
Jan 23, 2025
flyrain
approved these changes
Jan 23, 2025
amogh-jahagirdar
approved these changes
Jan 24, 2025
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Thanks @RussellSpitzer!
Member
Author
|
Merged, Thanks for the review @danielcweeks + @flyrain + @amogh-jahagirdar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.