Core: Expose table incremental scan for appends API in SerializableTable#10682
Merged
Conversation
nastra
approved these changes
Jul 11, 2024
Contributor
|
@deniskuzZ can you add the missing |
nastra
reviewed
Jul 11, 2024
| return lazyTable().newScan(); | ||
| } | ||
|
|
||
| public IncrementalAppendScan newIncrementalAppendScan() { |
Contributor
There was a problem hiding this comment.
can you also override newIncrementalChangelogScan() here please?
Member
Author
There was a problem hiding this comment.
thanks @nastra for the review! added missing @Override annotation
Member
Author
There was a problem hiding this comment.
+ newIncrementalChangelogScan() override
jasonf20
pushed a commit
to jasonf20/iceberg
that referenced
this pull request
Aug 4, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
required for HIVE-27101: Support incremental materialized view rebuild when Iceberg source tables have insert operation only