Allow for counter columns be static. Fixed in C* 2.0.7 - #724
Closed
ubombi wants to merge 1 commit into
Closed
Conversation
|
Hi @ubombi, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. Sincerely, |
|
Thank you @ubombi for signing the Contribution License Agreement. Cheers, |
Contributor
|
I mentioned it on IRC, but this should be a workaround for now: from cassandra.cqlengine import columns
from cassandra.cqlengine.models import Model
class MyModel(Model):
... # define PK, etc
static_counter = columns.Counter()
# The `static` attribute already exists, inherited from columns.Column
static_counter.static = TruePlease let me know if this doesn't work. As-is, this PR adds an argument to |
Contributor
|
I'm closing this PR. We will probably address it for the next major (PYTHON-926), and we'll credit you in the Git history then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CASSANDRA-6827 issue was resolver.
So we can enable static counters in ORM.
Tested manually on existing project.