Javascript-II - #1
Merged
Merged
Conversation
divbySeptember
left a comment
divbySeptember
left a comment
Collaborator
There was a problem hiding this comment.
Good job, I think you should look into away of simplifying your process
| // ==== Challenge 2: Use .map() ==== | ||
| // The event director needs to have all the runner's first names converted to uppercase because the director BECAME DRUNK WITH POWER. Convert each first name into all caps and log the result | ||
| let allCaps = []; | ||
| console.log(allCaps); |
Collaborator
There was a problem hiding this comment.
use const until you can't keep that in mind
| // Pass true to the callback if it is, otherwise pass false. | ||
| } | ||
| const checks = () => { | ||
| for (let i = 0; i < list.length; i++) { |
Collaborator
There was a problem hiding this comment.
how can you convert this into es6 instead of using for loops
| } | ||
| console.log('test', x); | ||
| return closureInner; | ||
| } |
Collaborator
There was a problem hiding this comment.
good job on the closure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MVP + 1 stretch afterhours