fix: permission pattern mismatch for tool-output directory #7875
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `external_directory` permission for `Truncate.DIR` was not matching because `external-directory.ts` creates glob patterns with `/*` suffix (e.g., `/Users/thomas/.local/share/opencode/tool-output/*`) but the allow rule was using the directory path without the suffix. This caused permission requests to fall through to the default "ask" action, which would hang indefinitely in headless/automated contexts (like ralph loops) where there's no UI to respond to the permission prompt. The fix updates the permission pattern in `agent.ts` to include the `/*` suffix to match the actual patterns being requested.
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Th0rgal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7876
external-directory.tsappends/*when creating permission patterns, butagent.tswas setting the allow rule without it. The patterns never matched, so permission requests fell through to "ask" and hung in headless mode.Changed
agent.tsto use${Truncate.DIR}/*instead ofTruncate.DIR.Tested by running the agent tests (
bun test agent.test.ts).