♻️Change quantity info types to static factories#1580
Closed
angularsen wants to merge 1 commit intoagl/unitconversion-in-quantityinfofrom
Closed
♻️Change quantity info types to static factories#1580angularsen wants to merge 1 commit intoagl/unitconversion-in-quantityinfofrom
angularsen wants to merge 1 commit intoagl/unitconversion-in-quantityinfofrom
Conversation
We already have generic support for quantity info, so adding concrete types for 100+ quantities seems a bit redundant and only used internally. - Change from concrete types to static factory classes, holding constant values and unit mappings as before - Merge method overloads, fall back to built-in resource manager if null is given - Change factory classes from `public` to `private`
Owner
Author
|
Blocked by #1578, merge conflict trying to target master so that change is temporarily included and targeting that branch. |
angularsen
changed the title
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Contributor
|
This PR was automatically closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have generic support for quantity info, so adding concrete types for 100+ quantities seems a bit redundant and only used internally.
publictoprivate