Merged
Conversation
Contributor
Author
|
I didn't touch the benchmark projects, as they would presumably no longer be comparable benchmarks - not sure how you want to handle those? |
angularsen
requested changes
Mar 23, 2025
Owner
angularsen
left a comment
angularsen
left a comment
There was a problem hiding this comment.
This looks ready to go, just a minor suggestion.
…ing dotnet run (i.e. avoid needing to specify `--framework net8.0`).
angularsen
force-pushed
the
aim/add-net9-to-v6
branch
from
9e4ed9f to
2c624da
Compare
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aiming to complete #1451 (the PR #1502 added .NET 9 for
masterbut notrelease/v6. I touched a few more projects and handledActivator.CreateInstancedifferently - happy to simply copy #1502 exactly if you prefer.