💚FluidResistance: Remove duplicate, invalid base units#1511
💚FluidResistance: Remove duplicate, invalid base units#1511angularsen merged 1 commit intomasterfrom
Conversation
Removing all base units except for the base unit and one more trivial variant.
|
@lipchev To fix the broken tests, I went ahead and remove most of the Just a heads up for when we merge into v6, and if you want to, you can add the correct definitions for the BaseUnits you think we should keep. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1511 +/- ##
=======================================
Coverage 84% 84%
=======================================
Files 368 370 +2
Lines 35606 35910 +304
=======================================
+ Hits 30005 30271 +266
- Misses 5601 5639 +38 ☔ View full report in Codecov by Sentry. |
Same here, I've got such an acute PTSD from these that as long as they aren't wrong- I don't care. |
Removing all base units except for
PascalSecondPerCubicMeterandPascalMinutePerCubicMeter.Duplicate base units caused SI UnitSystem tests to fail.