feat: throw TypeError for translationId

Gabriel Smolj&aacute;r · knalli · commit b363e3b68c1f · 2020-01-04T21:32:17.000+01:00
AngularJS 1.6 introduced a new behaviour that caused an exception on unhandled rejections of promises. If you were to pass undefined to to $translate the error message would simply be "Possibly unhandled rejection: undefined". With this change a TypeError is thrown instead so that you can easly find where the invalid translationId was passed from in the stack trace feat: throw TypeError for translationId AngularJS 1.6 introduced a new behaviour that caused an exception on unhandled rejections of promises. If you were to pass undefined to to $translate the error message would simply be "Possibly unhandled rejection: undefined". With this change a TypeError is thrown instead so that you can easly find where the invalid translationId was passed from in the stack trace (cherry picked from commit c4f5c24)
diff --git a/src/service/translate.js b/src/service/translate.js
@@ -1145,6 +1145,8 @@ function $translate($STORAGE_KEY, $windowProvider, $translateSanitizationProvide
       // trim off any whitespace
       if (translationId) {
         translationId = trim.apply(translationId);
+      } else {
+        throw new TypeError('translationId must be a not empty string');
       }
 
       var promiseToWaitFor = (function () {
diff --git a/test/unit/service/translate.spec.js b/test/unit/service/translate.spec.js
@@ -256,6 +256,10 @@ describe('pascalprecht.translate', function () {
       expect(value).toEqual(translationId);
     });
 
+    it('should throw if id is not a string or array of strings', function () {
+      expect(function () { $translate(undefined); }).toThrowError(TypeError);
+    });
+
     it('should return translation id if translation is null', function () {
       var deferred = $q.defer(),
         promise = deferred.promise,

Original file line number	Diff line number	Diff line change
`@@ -1145,6 +1145,8 @@ function $translate($STORAGE_KEY, $windowProvider, $translateSanitizationProvide`
`1145`	`1145`	`// trim off any whitespace`
`1146`	`1146`	`if (translationId) {`
`1147`	`1147`	`translationId = trim.apply(translationId);`
	`1148`	`+ } else {`
	`1149`	`+ throw new TypeError('translationId must be a not empty string');`
`1148`	`1150`	`}`
`1149`	`1151`
`1150`	`1152`	`var promiseToWaitFor = (function () {`