feat(@angular/cli): platform-electron-renderer#7435
feat(@angular/cli): platform-electron-renderer#7435dashkan wants to merge 2 commits intoangular:masterfrom
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
@hansl, I created a new PR. Same CLA block error. My GH primary email is the same as my google account w/ signed CLA. Thoughts? |
|
@ashkandaie That's because in your commits you use different email address. See: You'll need to set it to the email you signed CLA with and re-create/edit your commits. See here how to do it. Also check commit message guidelines. You'll need to fix it as well for build to pass. |
|
@ashkandaie This is an awesome addition thanks. Quick question, does 'ng serve' need to be blocked, I currently use and ejected webpack config with "target": "electron-renderer" and serve to localhost:4200 via 'webpack-dev-server' with no issues, would be good to retain this functionality if possible. |
|
I appreciate the time you took to make a PR for this, but we aren't ready yet to add new platforms and support them. We're tentatively adding |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Allows targeting electron renderer using the new platform property in .angular-cli.json.
Happy to add wiki story for the use case.
This resolves issue #5767