perf(forms): lazily instantiate signal form fields#67344
Merged
Conversation
angular-robot
Bot
added
area: performance
alxhub
added
action: merge
kirjs
approved these changes
Mar 18, 2026
Currently, Signal Forms eagerly instantiates all nodes in the form tree because `childrenMap` iterates over the `value` and creates a `FieldNode` for every property. This ensures validation side-effects are run early, but creates pure overhead for fields without validation logic unless explicitly accessed. This commit makes `childrenMap` lazy by default, skipping materialization for children without schema logic. This is achieved by introducing `hasLogicRules()` and `anyChildHasLogic()` across the `LogicNode` hierarchy. Fields are now only instantiated when a direct read occurs via `getChild()` (which calls the new `ensureChildrenMap()`) or if their subtree requires eager evaluation due to existing validation rules. Fixes angular#67212
alxhub
added
action: merge
Member
Author
|
Presubmit was "green" |
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Signal Forms eagerly instantiates all nodes in the form tree because
childrenMapiterates over thevalueand creates aFieldNodefor every property. This ensures validation side-effects are run early, but creates pure overhead for fields without validation logic unless explicitly accessed.This commit makes
childrenMaplazy by default, skipping materialization for children without schema logic. This is achieved by introducinghasLogicRules()andanyChildHasLogic()across theLogicNodehierarchy. Fields are now only instantiated when a direct read occurs viagetChild()(which calls the newensureChildrenMap()) or if their subtree requires eager evaluation due to existing validation rules.Fixes #67212