Skip to content

refactor(forms): remove unnecessary Array.from #50314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garrettld wants to merge 1 commit into from
Closed

refactor(forms): remove unnecessary Array.from #50314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(forms): remove unnecessary Array.from 
The Array.from isn't necessary since we're just iterating over the map keys.
  • Loading branch information
@garrettld
garrettld committed May 15, 2023
commit f6da0f2d0bcb64219ebf16cb57294c3a64d5b6f7
2 changes: 1 addition & 1 deletion packages/forms/src/directives/select_control_value_accessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export class SelectControlValueAccessor extends BuiltInControlValueAccessor impl

/** @internal */
_getOptionId(value: any): string|null {
for (const id of Array.from(this._optionMap.keys())) {
for (const id of this._optionMap.keys()) {
if (this._compareWith(this._optionMap.get(id), value)) return id;
}
return null;
Expand Down
2 changes: 1 addition & 1 deletion packages/forms/src/directives/select_multiple_control_value_accessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export class SelectMultipleControlValueAccessor extends BuiltInControlValueAcces

/** @internal */
_getOptionId(value: any): string|null {
for (const id of Array.from(this._optionMap.keys())) {
for (const id of this._optionMap.keys()) {
if (this._compareWith(this._optionMap.get(id)!._value, value)) return id;
}
return null;
Expand Down