Skip to content

build: lock file maintenance #50227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alan-agius4 wants to merge 1 commit into from
Closed

build: lock file maintenance #50227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,155 changes: 268 additions & 887 deletions aio/tools/examples/shared/yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.

1,377 changes: 610 additions & 767 deletions aio/yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.

33 changes: 0 additions & 33 deletions packages/core/test/bundling/animations/bundle.golden_symbols.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
{
"name": "APP_INITIALIZER"
},
{
"name": "AUTO_STYLE"
},
{
"name": "AnimationAstBuilderContext"
},
Expand Down Expand Up @@ -173,9 +170,6 @@
{
"name": "DIMENSIONAL_PROP_SET"
},
{
"name": "DI_DECORATOR_FLAG"
},
{
"name": "DOCUMENT"
},
Expand Down Expand Up @@ -218,9 +212,6 @@
{
"name": "ENVIRONMENT_INITIALIZER"
},
{
"name": "ERROR_ORIGINAL_ERROR"
},
Copy link
Member

@devversion devversion May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we understand why so many symbols are gone here? I assume Terser might have changed something?

I can help looking into it if you want. Potentially we would need to change the symbol extractor to "understand" a new "format"?

Copy link
Contributor Author

@alan-agius4 alan-agius4 May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect it might be related to a fix for terser/terser#1382 were dead code was previously not being removed.

Copy link
Member

@devversion devversion May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable.

{
"name": "EVENT_MANAGER_PLUGINS"
},
Expand Down Expand Up @@ -362,12 +353,6 @@
{
"name": "NG_TEMPLATE_SELECTOR"
},
{
"name": "NG_TEMP_TOKEN_PATH"
},
{
"name": "NG_TOKEN_PATH"
},
{
"name": "NOOP_CLEANUP_FN"
},
Expand All @@ -383,9 +368,6 @@
{
"name": "NO_CHANGE"
},
{
"name": "NO_NEW_LINE"
},
{
"name": "NO_PARENT_INJECTOR"
},
Expand Down Expand Up @@ -455,24 +437,15 @@
{
"name": "PLATFORM_INITIALIZER"
},
{
"name": "PLATFORM_SERVER_ID"
},
{
"name": "PRESERVE_HOST_CONTENT"
},
{
"name": "PRESERVE_HOST_CONTENT_DEFAULT"
},
{
"name": "PlatformRef"
},
{
"name": "R3Injector"
},
{
"name": "REMOVAL_FLAG"
},
{
"name": "REMOVE_STYLES_ON_COMPONENT_DESTROY"
},
Expand Down Expand Up @@ -515,9 +488,6 @@
{
"name": "SIMPLE_CHANGES_STORE"
},
{
"name": "SOURCE"
},
{
"name": "SafeSubscriber"
},
Expand Down Expand Up @@ -1544,9 +1514,6 @@
{
"name": "writeToDirectiveInput"
},
{
"name": "ɵPRE_STYLE"
},
{
"name": "ɵɵdefineComponent"
},
Expand Down
24 changes: 0 additions & 24 deletions packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,6 @@
{
"name": "DEFAULT_APP_ID"
},
{
"name": "DI_DECORATOR_FLAG"
},
{
"name": "DOCUMENT"
},
Expand Down Expand Up @@ -125,9 +122,6 @@
{
"name": "ENVIRONMENT_INITIALIZER"
},
{
"name": "ERROR_ORIGINAL_ERROR"
},
{
"name": "EVENT_MANAGER_PLUGINS"
},
Expand Down Expand Up @@ -263,12 +257,6 @@
{
"name": "NG_TEMPLATE_SELECTOR"
},
{
"name": "NG_TEMP_TOKEN_PATH"
},
{
"name": "NG_TOKEN_PATH"
},
{
"name": "NOOP_CLEANUP_FN"
},
Expand All @@ -284,9 +272,6 @@
{
"name": "NO_CHANGE"
},
{
"name": "NO_NEW_LINE"
},
{
"name": "NO_PARENT_INJECTOR"
},
Expand Down Expand Up @@ -338,15 +323,9 @@
{
"name": "PLATFORM_INITIALIZER"
},
{
"name": "PLATFORM_SERVER_ID"
},
{
"name": "PRESERVE_HOST_CONTENT"
},
{
"name": "PRESERVE_HOST_CONTENT_DEFAULT"
},
{
"name": "PlatformRef"
},
Expand Down Expand Up @@ -383,9 +362,6 @@
{
"name": "SIMPLE_CHANGES_STORE"
},
{
"name": "SOURCE"
},
{
"name": "SafeSubscriber"
},
Expand Down
36 changes: 0 additions & 36 deletions packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,6 @@
{
"name": "ENVIRONMENT_INITIALIZER"
},
{
"name": "ERROR_ORIGINAL_ERROR"
},
{
"name": "EVENT_MANAGER_PLUGINS"
},
Expand Down Expand Up @@ -347,12 +344,6 @@
{
"name": "NG_TEMPLATE_SELECTOR"
},
{
"name": "NG_TEMP_TOKEN_PATH"
},
{
"name": "NG_TOKEN_PATH"
},
{
"name": "NG_VALIDATORS"
},
Expand All @@ -374,9 +365,6 @@
{
"name": "NO_CHANGE"
},
{
"name": "NO_NEW_LINE"
},
{
"name": "NO_PARENT_INJECTOR"
},
Expand Down Expand Up @@ -437,9 +425,6 @@
{
"name": "Optional"
},
{
"name": "PARAMETERS"
},
{
"name": "PLATFORM_DESTROY_LISTENERS"
},
Expand All @@ -449,15 +434,9 @@
{
"name": "PLATFORM_INITIALIZER"
},
{
"name": "PLATFORM_SERVER_ID"
},
{
"name": "PRESERVE_HOST_CONTENT"
},
{
"name": "PRESERVE_HOST_CONTENT_DEFAULT"
},
{
"name": "PlatformRef"
},
Expand Down Expand Up @@ -518,9 +497,6 @@
{
"name": "SIMPLE_CHANGES_STORE"
},
{
"name": "SOURCE"
},
{
"name": "SafeSubscriber"
},
Expand Down Expand Up @@ -602,9 +578,6 @@
{
"name": "VE_ViewContainerRef"
},
{
"name": "VIEW_REFS"
},
{
"name": "Validators"
},
Expand Down Expand Up @@ -650,9 +623,6 @@
{
"name": "_enable_super_gross_mode_that_will_cause_bad_things"
},
{
"name": "_findMatchingDehydratedViewImpl"
},
{
"name": "_getInsertInFrontOfRNodeWithI18n"
},
Expand Down Expand Up @@ -956,9 +926,6 @@
{
"name": "findAttrIndexInNode"
},
{
"name": "findMatchingDehydratedView"
},
{
"name": "findStylingValue"
},
Expand Down Expand Up @@ -1157,9 +1124,6 @@
{
"name": "handleError"
},
{
"name": "hasInSkipHydrationBlockFlag"
},
{
"name": "hasParentInjector"
},
Expand Down
36 changes: 0 additions & 36 deletions packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,6 @@
{
"name": "ENVIRONMENT_INITIALIZER"
},
{
"name": "ERROR_ORIGINAL_ERROR"
},
{
"name": "EVENT_MANAGER_PLUGINS"
},
Expand Down Expand Up @@ -329,12 +326,6 @@
{
"name": "NG_TEMPLATE_SELECTOR"
},
{
"name": "NG_TEMP_TOKEN_PATH"
},
{
"name": "NG_TOKEN_PATH"
},
{
"name": "NG_VALIDATORS"
},
Expand All @@ -356,9 +347,6 @@
{
"name": "NO_CHANGE"
},
{
"name": "NO_NEW_LINE"
},
{
"name": "NO_PARENT_INJECTOR"
},
Expand Down Expand Up @@ -428,9 +416,6 @@
{
"name": "Optional"
},
{
"name": "PARAMETERS"
},
{
"name": "PLATFORM_DESTROY_LISTENERS"
},
Expand All @@ -440,15 +425,9 @@
{
"name": "PLATFORM_INITIALIZER"
},
{
"name": "PLATFORM_SERVER_ID"
},
{
"name": "PRESERVE_HOST_CONTENT"
},
{
"name": "PRESERVE_HOST_CONTENT_DEFAULT"
},
{
"name": "PlatformRef"
},
Expand Down Expand Up @@ -506,9 +485,6 @@
{
"name": "SIMPLE_CHANGES_STORE"
},
{
"name": "SOURCE"
},
{
"name": "SafeSubscriber"
},
Expand Down Expand Up @@ -596,9 +572,6 @@
{
"name": "VE_ViewContainerRef"
},
{
"name": "VIEW_REFS"
},
{
"name": "ViewContainerRef"
},
Expand Down Expand Up @@ -641,9 +614,6 @@
{
"name": "_enable_super_gross_mode_that_will_cause_bad_things"
},
{
"name": "_findMatchingDehydratedViewImpl"
},
{
"name": "_getInsertInFrontOfRNodeWithI18n"
},
Expand Down Expand Up @@ -926,9 +896,6 @@
{
"name": "findAttrIndexInNode"
},
{
"name": "findMatchingDehydratedView"
},
{
"name": "findStylingValue"
},
Expand Down Expand Up @@ -1121,9 +1088,6 @@
{
"name": "handleError"
},
{
"name": "hasInSkipHydrationBlockFlag"
},
{
"name": "hasParentInjector"
},
Expand Down
Loading