Skip to content

Template Pipeline 3: For a Few Templates More #50118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alxhub wants to merge 13 commits into from
Closed

Template Pipeline 3: For a Few Templates More #50118

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
eb36071
refactor(compiler): support literal array/maps in the template pipeline
alxhub May 2, 2023
c02b566
refactor(compiler): generalize interpolation calling for v-arg functions
alxhub Apr 25, 2023
407e83f
refactor(compiler): add `UsesVarOffset` trait to template pipeline
alxhub Apr 26, 2023
15be72c
refactor(compiler): add shared constant concept to `ConstantPool`
alxhub May 1, 2023
2f592b9
refactor(compiler): add `ConstantPool` to template pipeline compilations
alxhub May 1, 2023
3f6e4ba
refactor(compiler): add pure function support to the template pipeline
alxhub May 2, 2023
91fd071
refactor(compiler): transform all expressions in the template pipeline
alxhub May 2, 2023
8f334a0
refactor(compiler): purify literal arrays and maps in template pipeline
alxhub May 2, 2023
20b3082
refactor(compiler): convert conditional ast in template pipeline
alxhub May 2, 2023
c87f3bd
refactor(compiler): fix `insertBefore` ownership logic
alxhub May 2, 2023
34b42c1
refactor(compiler): support pipes in the template pipeline
alxhub May 2, 2023
c872ce4
refactor(compiler): write expressions in the template pipeline
alxhub May 2, 2023
f488a2f
refactor(compiler): support property interpolation in the template pi…
alxhub May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(compiler): add ConstantPool to template pipeline compilations 
This commit adds the `ConstantPool` to `ComponentCompilation`, making it
available to all phases of the template pipeline. Constant extraction is a
common operation in pipeline phases.
  • Loading branch information
@alxhub
alxhub committed May 9, 2023
commit 2f592b9106d09dceac7e81375bd485f982f102d2
2 changes: 1 addition & 1 deletion packages/compiler/src/render3/view/compiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ export function compileComponentFromMetadata(
} else {
// This path compiles the template using the prototype template pipeline. First the template is
// ingested into IR:
const tpl = ingest(meta.name, meta.template.nodes);
const tpl = ingest(meta.name, meta.template.nodes, constantPool);

// Then the IR is transformed to prepare it for cod egeneration.
transformTemplate(tpl);
Expand Down
3 changes: 2 additions & 1 deletion packages/compiler/src/template/pipeline/src/compilation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/

import {ConstantPool} from '../../../constant_pool';
import * as o from '../../../output/output_ast';
import * as ir from '../ir';

Expand Down Expand Up @@ -36,7 +37,7 @@ export class ComponentCompilation {
*/
readonly root: ViewCompilation;

constructor(readonly componentName: string) {
constructor(readonly componentName: string, readonly pool: ConstantPool) {
// Allocate the root view.
const root = new ViewCompilation(this, this.allocateXrefId(), null);
this.views.set(root.xref, root);
Expand Down
6 changes: 4 additions & 2 deletions packages/compiler/src/template/pipeline/src/ingest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/

import {ConstantPool} from '../../../constant_pool';
import * as e from '../../../expression_parser/ast';
import * as o from '../../../output/output_ast';
import * as t from '../../../render3/r3_ast';
Expand All @@ -18,8 +19,9 @@ import {BINARY_OPERATORS} from './conversion';
* Process a template AST and convert it into a `ComponentCompilation` in the intermediate
* representation.
*/
export function ingest(componentName: string, template: t.Node[]): ComponentCompilation {
const cpl = new ComponentCompilation(componentName);
export function ingest(
componentName: string, template: t.Node[], constantPool: ConstantPool): ComponentCompilation {
const cpl = new ComponentCompilation(componentName, constantPool);
ingestNodes(cpl.root, template);
return cpl;
}
Expand Down