build: run //packages/common/http/test on Node.js 18 (#50247)

alan-agius4 · alxhub · commit 37d3664cf5f5 · 2023-06-08T09:48:11.000-07:00
This commits adds configures `//packages/common/http/test` to use Node.js 18 toolchain which is needed to test the fetch implementation which use Node.js 18 APIs. We also disable RBE for this target as it doesn't work with Node.js 18 right now. See angular/dev-infra#1017 PR Close #50247
diff --git a/WORKSPACE b/WORKSPACE
@@ -67,6 +67,11 @@ nodejs_register_toolchains(
     node_version = "16.14.0",
 )
 
+nodejs_register_toolchains(
+    name = "node18",
+    node_version = "18.10.0",
+)
+
 # Download npm dependencies.
 load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install")
 load("//integration:npm_package_archives.bzl", "npm_package_archives")
diff --git a/packages/common/http/test/BUILD.bazel b/packages/common/http/test/BUILD.bazel
@@ -29,6 +29,17 @@ ts_library(
 jasmine_node_test(
     name = "test",
     bootstrap = ["//tools/testing:node"],
+    tags = [
+        # Remote execution doesn't work with Node.js 18 right now.
+        # See https://github.com/angular/dev-infra/issues/1017
+        "no-remote-exec",
+    ],
+    # TODO remove once the Node 18 is the default toolchain.
+    toolchain = select({
+        "@bazel_tools//src/conditions:linux_x86_64": "@node18_linux_amd64//:node_toolchain",
+        "@bazel_tools//src/conditions:darwin": "@node18_darwin_amd64//:node_toolchain",
+        "@bazel_tools//src/conditions:windows": "@node18_windows_amd64//:node_toolchain",
+    }),
     deps = [
         ":test_lib",
     ],
