Skip to content

🐛 [Story Preview] Enable amp-video to play in preview mode #38149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coreymasanto merged 21 commits into from
May 9, 2022
Merged

🐛 [Story Preview] Enable amp-video to play in preview mode #38149

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0b5caca
Enable amp-video to play in preview mode
coreymasanto Apr 27, 2022
f8d608c
Merge branch 'main' into previewPlayVideo
coreymasanto Apr 27, 2022
0865899
First draft of video re-registration
coreymasanto Apr 28, 2022
b5d291d
Add reregistration logic
coreymasanto Apr 29, 2022
aa9bfad
Add storyIsBeingPreviewed_() method to amp-story-page
coreymasanto Apr 29, 2022
89e4320
Refactor and comment reregister logic in amp-story-page.js
coreymasanto Apr 29, 2022
34b982e
Add missing comments/descriptions
coreymasanto May 2, 2022
54de52b
Lint
coreymasanto May 2, 2022
b70f7b7
Merge branch 'main' into previewPlayVideo
coreymasanto May 3, 2022
9cdae2d
Remove unnecessary indentation
coreymasanto May 4, 2022
7ee5070
Move the reregistration-specific logic in registration() to its corre…
coreymasanto May 4, 2022
2b8f1c2
Update incomplete method description
coreymasanto May 4, 2022
a6083d2
Ensure that an ID is used instead of 'undefined'
coreymasanto May 4, 2022
894d9a1
Lint
coreymasanto May 4, 2022
ddc741a
Allow for custom sources when resetting media pool elements
coreymasanto May 4, 2022
fed1f5f
Lint
coreymasanto May 5, 2022
9ef2839
Update Sources.removeFrom() to use video sources instead of amp-video…
coreymasanto May 6, 2022
b1b9a2d
Toggle the video error message off before attempting to replay the video
coreymasanto May 9, 2022
79f449e
Rename reregisterUnplayedVideos_() to the more accurate reregisterAnd…
coreymasanto May 9, 2022
40443fe
Merge branch 'main' into previewPlayVideo
coreymasanto May 9, 2022
a9f2a6f
Use getAllVideos_() instead of an unnecessary reimplementation
coreymasanto May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint
  • Loading branch information
@coreymasanto
coreymasanto committed May 2, 2022
commit 54de52bd3bf5ed51b30a25893106dc1c3830145c
2 changes: 1 addition & 1 deletion extensions/amp-story/1.0/media-pool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ export class MediaPool {
* should be registered as early as possible, in order to prevent them from
* being played while not managed by the media pool. Registering elements
* from within the pool is not allowed, and will also be a no-op.
*
*
* If the media element is already registered and `isReregistration` is true,
* then the media element will be loaded. However, if the element is
* registered and `isReregistration` is false, then this is a no-op.
Expand Down