♻️ ✅ [amp story shopping] Move i18n CTA label logic into shopping-attachment component#37515
Merged
processprocess merged 1 commit intoampproject:mainfrom Jan 31, 2022
Merged
Conversation
jshamble
approved these changes
Jan 31, 2022
Contributor
jshamble
left a comment
jshamble
left a comment
There was a problem hiding this comment.
LGTM!
nit: It may be worth playing around and refactoring some of the calls at the beginning of some of the in the unit tests into a helper function to enforce DRY.
|
Hey @gmajoulet! These files were changed: Hey @newmuis, @mszylkowski! These files were changed: |
gmajoulet
approved these changes
Jan 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR encapsulates shopping attachment logic by setting the
cta-textattribute on the inner page-attachment element and includes a unit test.