fix: use launch_with_termination_handler for clean experiment termina… #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion
This PR addresses issue #312 by updating all example scripts to use lp_utils.launch_with_termination_handler() instead of lp.launch() directly.
The launch_with_termination_handler() function wraps lp.launch() with a signal handler that ensures all Launchpad processes are properly terminated when the parent process receives a SIGTERM or SIGINT signal. This prevents the messy teardown messages like:
'Worker groups that did not terminate in time: ['actor'] Killing entire runtime.'
This is especially important when using external loggers like Weights and Biases, which previously reported experiments as 'crashed' even though they completed successfully.
Files updated:
Fixes #312