Fix allure_full_name parsing when square bracers is in param contents #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delatrie
requested changes
Nov 23, 2022
Contributor
delatrie
left a comment
delatrie
left a comment
There was a problem hiding this comment.
The new allure_full_name algorithm is much nicer now, but it omits a dot before a class name:
I made some suggestions to fix.
allure-pytest/test/acceptance/parametrization/parametrization_test.py
Outdated
Show resolved
Hide resolved
skhomuti
force-pushed
the
full_name_fix
branch
from
ca3af86 to
8c5a792
Compare
delatrie
approved these changes
Nov 23, 2022
baev
approved these changes
Nov 23, 2022
beckerGil
pushed a commit
to beckerGil/allure-python
that referenced
this pull request
Apr 10, 2023
IvanBuruyane
pushed a commit
to IvanBuruyane/allure-python
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #622
also fix typo in test names
Context
Checklist