Skip to content

Conversation

@Denis-Alexeev
Copy link
Contributor

@Denis-Alexeev Denis-Alexeev commented Mar 3, 2021

fixes #440

Context

When allure.step decorates function with positional and keyword args, then allure fails with KeyError if any positional argument was passed as keyword argument during function call.

Checklist

  • [Sign Allure CLA][cla]
  • Provide unit tests

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2021

CLA assistant check
All committers have signed the CLA.

@Denis-Alexeev Denis-Alexeev changed the title Add an ability to pass positional args as keyword (fixes #440) Add an ability to pass positional args as keyword (fixes #440\) Mar 3, 2021
@Denis-Alexeev Denis-Alexeev changed the title Add an ability to pass positional args as keyword (fixes #440\) Add an ability to pass positional args as keyword (fixes #440) Mar 3, 2021
@Denis-Alexeev
Copy link
Contributor Author

Hello, Guys! Could you please take a look and review the changes?

@sseliverstov
Copy link
Contributor

@Denis-Alexeev Thank you for your contribution, can you update branch please?

@Denis-Alexeev
Copy link
Contributor Author

@sseliverstov Done.

@Denis-Alexeev
Copy link
Contributor Author

Hello, Guys! Could you please take a look and review the changes?

@sseliverstov sseliverstov merged commit b2e64d4 into allure-framework:master May 19, 2021
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@allure.step decorator fails if one of the method parameters has a default value

3 participants