Skip to content

Upgrade to php 84#115

Merged
delatrie merged 4 commits intoallure-framework:mainfrom
krchiper:upgrade-to-php-84
Apr 9, 2025
Merged

Upgrade to php 84#115
delatrie merged 4 commits intoallure-framework:mainfrom
krchiper:upgrade-to-php-84

Conversation

@krchiper
Copy link
Contributor

@krchiper krchiper commented Mar 25, 2025 •
edited
Loading

This PR is based on PR #114 (Fix ci pipeline) and therefore includes the same fixes as that

Psalm drives alot of conflicting packages into this one, so the conflict section in composer.json is growing

Code coverage hint for ExceptionDetailsTraitTest has been removed as I can't get it to work with both php 8.1 -> 8.4

// #[CoversTrait(ExceptionDetailsTrait::class)]  <--- needed by phpunit 12
// #[CoversClass(ExceptionDetailsTrait::class)]  <--- needed by phpunit 10 + 11
final class ExceptionDetailsTraitTest extends TestCase

Psalm upgraded to latest version and fixes applied to code base

@krchiper krchiper mentioned this pull request Mar 25, 2025
Closed
@krchiper
Copy link
Contributor Author

krchiper commented Mar 28, 2025

Can you approve checks?

delatrie
delatrie approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@delatrie delatrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @krchiper !
Thank you for your contribution. I have a couple of things to fix before releasing it. Hopefully, it won't take long.

@delatrie delatrie merged commit 89404e9 into allure-framework:main Apr 9, 2025
25 checks passed
This was referenced Apr 9, 2025
Closed
Closed
Closed
Closed
@krchiper krchiper deleted the upgrade-to-php-84 branch April 9, 2025 13:45
@krchiper krchiper restored the upgrade-to-php-84 branch April 10, 2025 07:58
@glo71317
Copy link

glo71317 commented Apr 10, 2025

@delatrie Thank you for adding the support! When can we expect the stable version to be released?

@delatrie delatrie mentioned this pull request Apr 17, 2025
Merged
@delatrie delatrie added new feature type:new feature New feature or request and removed new feature type:new feature New feature or request labels Apr 17, 2025
@delatrie
Copy link
Contributor

delatrie commented Apr 18, 2025

@glo71317 It has just been released as 3.1.0.

@delatrie delatrie linked an issue Jan 2, 2026 that may be closed by this pull request
allure-framework/allure-phpunit will require PHP 8.4 support #110
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delatrie delatrie delatrie approved these changes

Assignees

@delatrie delatrie

Labels

type:new feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allure-framework/allure-phpunit will require PHP 8.4 support

3 participants

@krchiper @glo71317 @delatrie