Skip to content

Change TestSuite class for PHP 8.1 compatibility#81

Merged
baev merged 1 commit intoallure-framework:masterfrom
SilinMykola:php81-compatibility/change-test-suite-class
Nov 15, 2021
Merged

Change TestSuite class for PHP 8.1 compatibility#81
baev merged 1 commit intoallure-framework:masterfrom
SilinMykola:php81-compatibility/change-test-suite-class

Conversation

@SilinMykola
Copy link
Contributor

Hello! We tried to update our project for PHP 8.1 compatibility but had an error with your module. I made some changes to fix compatibility with PHP8.1.
Please check. Thanks!

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2021

CLA assistant check
All committers have signed the CLA.

@baev
Copy link
Member

baev commented Nov 10, 2021

BTW check out a new version https://github.com/allure-framework/allure-php-commons2

@SilinMykola SilinMykola force-pushed the php81-compatibility/change-test-suite-class branch from 6f6b54f to 2ca6659 Compare November 10, 2021 15:09
@andrewbess
Copy link

Hello @baev
Thank you for your proposition.
However, I think it would be great if this library also will be compatible with PHP 8.1.
What you think about it?

@SilinMykola
Copy link
Contributor Author

Hello @baev ! Could you help with this PR? Thank you!

@baev baev merged commit 7906840 into allure-framework:master Nov 15, 2021
@SilinMykola SilinMykola deleted the php81-compatibility/change-test-suite-class branch November 15, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants