add php 7.4 support (update jms serializer v3 + phpUnit) + fix issue 41#54
add php 7.4 support (update jms serializer v3 + phpUnit) + fix issue 41#54medliii wants to merge 2 commits intoallure-framework:masterfrom medliii:master
Conversation
medliii
changed the title
| ] | ||
| ); | ||
|
|
||
| AnnotationRegistry::registerAutoloadNamespace( |
|
I hope this gets fixed ASAP. It's an obstacle for our test runs. |
| * @expectedException Exception | ||
| */ | ||
| public function testExecuteFailingStep() | ||
| public function te1stExecuteFailingStep() |
There was a problem hiding this comment.
Change this back to testExecuteFailingStep
|
@medliii Do you have proof of it working with real phpunit test? Can you share screenshots of the same? |
|
|
eroshenkoam
added
the
type:dependencies
|
Bump! Is there any way for me to help with accepting this PR? |
I don't know the original author's intention, but in general it's useless or even harmful to keep composer.lock in libraries. When the package is installed as a library, it's lock file is ignored; that means that "stable" combination of dependencies that was tested is never preserved. So I'd rather advice to delete it, too. |
|
This PR seems to be abandoned, so I've resolved conflicts in another PR #65. |
|
closed via #65 |
6 participants
Plus fix 41 via change
public static function registerAnnotationNamespaces() { AnnotationRegistry::registerUniqueLoader('class_exists'); }doctrine/annotations 2 won't support AnnotationRegistry::register*
And this behavior will be by default
doctrine/annotations#205