Allows more recent versions of the dependencies jms/serializer and sy…#46
Merged
baev merged 1 commit intoallure-framework:masterfrom Jan 9, 2020
Merged
Conversation
…mfony/http-foundation to be installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mfony/http-foundation to be installed.
Fixes #45
After changing the
composer.jsonfile, I rancomposer update jms/serializer symfony/http-foundationso thecomposer.lockfile is also up2date. Doing so executed the following actions:I checked compatibility of
symfony/http-foundationand this should be safe to use until version 5.0.0, which will drop support forSymfony\Component\HttpFoundation\File\MimeType\ExtensionGuesserandSymfony\Component\HttpFoundation\File\MimeType\MimeTypeGuesser: https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md#500Those two classes are already being deprecated in Symfony 4.3 btw:
I haven't checked compatibility of
jms/serializerwith its 1.x versions, but I think it should be safe.Thanks!