Modernize standards and remove redundant deps#39
Conversation
|
The CLAassistant doesn't seem to realize that I signed the CLA. Am I missing something? |
|
Is anyone processing active PRs for this repo? |
|
@mihaeu sorry for the delay
Seems like the email you are using to commit is not specified in Github settings. |
|
Thanks @baev
I missed the part where it said exactly what the problem is :) I added the email address and not when I click on the CLA it tells me that it's already signed, but the build state is unchanged. Can you manually trigger a re-check? UPDATE: Nevermind I just rebased and pushed again and that triggered the check. Feel free to merge, and thanks again ;) |
6b91832 to
014d5e2
Compare
|
@mihaeu all good now 👍 (you missed the part where you can trigger recheck by clicking the link 😄 ) |
Friday, 4pm :) thanks for your patience ;) |
Hey there,
thanks for this project!
I was unable to use it for a project of mine because of the required math extension (which is actually not required by the code).
This PR:
Is this fine with you?