Skip to content

Modernize standards and remove redundant deps#39

Merged
baev merged 3 commits intoallure-framework:masterfrom
mihaeu:modernize-standards-and-remove-redundant-deps
May 25, 2018
Merged

Modernize standards and remove redundant deps#39
baev merged 3 commits intoallure-framework:masterfrom
mihaeu:modernize-standards-and-remove-redundant-deps

Conversation

@mihaeu
Copy link
Contributor

@mihaeu mihaeu commented Feb 20, 2018

Hey there,

thanks for this project!

I was unable to use it for a project of mine because of the required math extension (which is actually not required by the code).

This PR:

  • adds whitelists for phpunit coverage
  • fixes composer dependencies with proper version constraints and separation of dev- prod-reqs
  • adds composer.lock file (recommended by the Composer project to avoid surprises in production)

Is this fine with you?

@CLAassistant
Copy link

CLAassistant commented Feb 20, 2018

CLA assistant check
All committers have signed the CLA.

@mihaeu
Copy link
Contributor Author

mihaeu commented Feb 21, 2018

The CLAassistant doesn't seem to realize that I signed the CLA. Am I missing something?

@mihaeu
Copy link
Contributor Author

mihaeu commented May 25, 2018

Is anyone processing active PRs for this repo?

@baev
Copy link
Member

baev commented May 25, 2018

@mihaeu sorry for the delay

The CLAassistant doesn't seem to realize that I signed the CLA. Am I missing something?

Seems like the email you are using to commit is not specified in Github settings.

@mihaeu
Copy link
Contributor Author

mihaeu commented May 25, 2018

Thanks @baev

Seems like the email you are using to commit is not specified in Github settings.

I missed the part where it said exactly what the problem is :) I added the email address and not when I click on the CLA it tells me that it's already signed, but the build state is unchanged. Can you manually trigger a re-check?

UPDATE: Nevermind I just rebased and pushed again and that triggered the check. Feel free to merge, and thanks again ;)

@mihaeu mihaeu force-pushed the modernize-standards-and-remove-redundant-deps branch from 6b91832 to 014d5e2 Compare May 25, 2018 14:00
@baev
Copy link
Member

baev commented May 25, 2018

@mihaeu all good now 👍 (you missed the part where you can trigger recheck by clicking the link 😄 )

@mihaeu
Copy link
Contributor Author

mihaeu commented May 25, 2018

all good now +1 (you missed part where you can trigger recheck by clicking the link smile )

Friday, 4pm :) thanks for your patience ;)

@baev baev merged commit c7a6758 into allure-framework:master May 25, 2018
@baev
Copy link
Member

baev commented May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants