fix(descriptions-javadoc): put descriptions in META-INF folder#971
Merged
baev merged 3 commits intoallure-framework:masterfrom Oct 19, 2023
Merged
fix(descriptions-javadoc): put descriptions in META-INF folder#971baev merged 3 commits intoallure-framework:masterfrom
baev merged 3 commits intoallure-framework:masterfrom
Conversation
baev
requested changes
Oct 19, 2023
allure-java-commons/src/main/java/io/qameta/allure/util/ResultsUtils.java
Outdated
Show resolved
Hide resolved
baev
approved these changes
Oct 19, 2023
Member
|
@rPraml thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We have a multi module project, where we have a "commons-junit" maven module.
The "commons-junit" module provides some basic tests in an abstract class, that other modules can can (re)use.
Now we want to add module-infos in all our modules and we come across the problem, that
allure-descriptions-javadocputs the descriptions in the folderallureDescriptions.As this looks like a package, we get the jpms split package situation and get the error
This PR changes the destination from
allureDescriptionstoMETA-INF/allureDescriptionsas suggested herehttps://stackoverflow.com/questions/69526033/how-to-add-resources-to-two-modular-jars-in-same-named-folders
This will solve our problem, but I cannot estimate, if there are thirdParty frameworks, that rely on the folder location
Example use case
Content of the "commons-junit" module
Content of other module (depends on commons-junit)
Checklist