Lazy load logger in ResultUtils to supress SLF4J warings in AnnotationProcessing#968
Closed
rPraml wants to merge 2 commits intoallure-framework:masterfrom
Closed
Lazy load logger in ResultUtils to supress SLF4J warings in AnnotationProcessing#968rPraml wants to merge 2 commits intoallure-framework:masterfrom
rPraml wants to merge 2 commits intoallure-framework:masterfrom
Conversation
Contributor
Author
|
@baev maybe you can provide feedback to this change |
Member
|
fixed via #981 |
Member
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The JavaDocDescriptionsProcessor requires the
ResultsUtils.generateMethodSignatureHashWhen the ResultsUtils class is loaded during AnnotationProcessing, it has initialized also the SLF4J framework, which leads to some SLF4J warnings while compiling.
Getting the logger only, when it is really needed will solve the issue (in theoretical more costs in performance, but this does not matter here)
See #962 for more info
Checklist