-
-
Notifications
You must be signed in to change notification settings - Fork 419
Fix preview tally #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BitRate27
wants to merge
22
commits into
DistroAV:master
Choose a base branch
from
BitRate27:fixpreviewtally
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix preview tally #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle all cases of toggling visibility Add comments Send tally on new receiver Remove unneeded comment Clang format Fix mac and linux builds Fix mac and linux build Add empty line at end of ndi-source
… into fixpreviewtally
paulpv
reviewed
Sep 5, 2025
paulpv
reviewed
Sep 5, 2025
… preview everywhere.
… into fixpreviewtally
… into fixpreviewtally
Collaborator
|
@BitRate27 last part for this would be to have a new "deterministic" documentation :
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue brought up in NDI Tally Light Issues....
In summary, when a source is in program, and not in preview, the preview tally is still sent to the camera. This appears as red and green bars at the top of NDI Studio Monitor, or a camera tally light flashing red/green as reported in the original issue above.
This PR also allows the preview tally to reflect the state of the visible setting of a source's scene item.
The cause of the issues is that the show/hidden callbacks and state retrieval methods in OBS, do not reflect the preview state of sources.
To try to properly fix the issue, in the OBS PR Allow sources to know when it is being previewed, preview/depreview callbacks were added to OBS, similar to the activate/deactivate/hide/show callbacks. Since the OBS PR has been sitting for 6 months and comments in the PR suggest the risk is too great to change OBS at this level, this PR implements the preview/depreview APIs in obs-support/obs-source-preview.cpp. This solution provides a simple way for the NDI source to implement preview tally correctly, by merely using the preview/depreview APIs instead of show/hide.
The majority of the code is in the obs-support/obs-source-preview.cpp which uses Frontend events and scene item signals to maintain the preview state of a NDI source.
The visibility of a source in the preview scene can be altered in the following ways:
All these events/signals should cause a new tally state to be sent to the camera.
As an added complication, OBS scene item APIs, specifically the signals, do not operate as expected in the following ways:
A good part of the code in obs-source-preview is to deal with these deficiencies.
This PR was tested by:
Once setup, testing was done by altering the visibility of the NDI sources as listed above and verifying the tallys shown in NDI Studio Monitor are correct.