Skip to content

chore: setup release please to support changelog development#443

Merged
lwasser merged 2 commits intoall-contributors:mainfrom
lwasser:release-please
Feb 21, 2026
Merged

chore: setup release please to support changelog development#443
lwasser merged 2 commits intoall-contributors:mainfrom
lwasser:release-please

Conversation

@lwasser
Copy link
Member

@lwasser lwasser commented Feb 15, 2026 •
edited
Loading

THis PR closes #442

It creates a config file for release please. i tested this on my fork and it seems to work well!
It uses conventional commits to trigger releases so if we create a new pr with a commit that has fix, or feat etc it will trigger a build. this then pushes us one step closer to creating an actual npm release.

Why:

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@lwasser lwasser marked this pull request as ready for review February 15, 2026 20:06
@lwasser lwasser requested a review from JimMadge February 19, 2026 00:50
@lwasser
Copy link
Member Author

lwasser commented Feb 19, 2026

heya @JimMadge @JoshuaKGoldberg @jdalrymple if you want to see what this looks like in action, a demo pr is here:

lwasser#3

We want to set up a deploy to NPM soon, but I don't think we are quite ready yet. But we do have commits that would trigger a release (ie a fix: pr that i just merged)!!

@jdalrymple
Copy link
Contributor

jdalrymple commented Feb 19, 2026

This is slick!

@jdalrymple
Copy link
Contributor

jdalrymple commented Feb 19, 2026

Is there anything remaining for this PR? Its LGTM, but want to make sure before I ✅

@lwasser lwasser mentioned this pull request Feb 20, 2026
Open
@lwasser lwasser requested review from JimMadge and JoshuaKGoldberg and removed request for JimMadge February 20, 2026 02:17
@lwasser
Copy link
Member Author

lwasser commented Feb 20, 2026

Is there anything remaining for this PR? Its LGTM, but want to make sure before I ✅

@jdalrymple It's good to go - I just rebased!! I just re-invited you to the org. I'll be curious to know if you are able to approve the pr without being an org member. I can't actually request a review from you now and I can't add you to the maintainer team and give you permissions until you accept the invitation to the org. ✨

When we merge, we will see if the permissions are set up correctly. They should be but... you know how that can go!

@lwasser @jdalrymple
chore(release): add release please to manage changelog
ac22e7a 
Apply suggestion from @lwasser

Apply suggestion from @lwasser

chore: add manifest and update version

chore: lint
@lwasser @jdalrymple
Apply suggestion from @lwasser
992541d
jdalrymple
jdalrymple approved these changes Feb 20, 2026
View reviewed changes
Copy link
Contributor

@jdalrymple jdalrymple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lwasser
Copy link
Member Author

lwasser commented Feb 21, 2026

Thank you!! I"ll merge then and we'll see how it goes!!

@lwasser lwasser merged commit 7ffde6c into all-contributors:main Feb 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdalrymple jdalrymple jdalrymple approved these changes

@JimMadge JimMadge Awaiting requested review from JimMadge

@JoshuaKGoldberg JoshuaKGoldberg Awaiting requested review from JoshuaKGoldberg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: setup release-please

2 participants

@lwasser @jdalrymple