feat: Complete P2PConnector implementation for high-performance PD Disaggregation#997
Open
ZhihanYan wants to merge 1 commit into
Open
feat: Complete P2PConnector implementation for high-performance PD Disaggregation#997ZhihanYan wants to merge 1 commit into
ZhihanYan wants to merge 1 commit into
Conversation
Collaborator
AI Code Review - PR #997Status: LGTM Summary: P0/0 · P1/0 · P2/0 · P3/0 lgtm ready to ci Checklist Violations (1 fail / 56 total)General Principles Checklist
Strengths
|
Collaborator
|
internal source has been updated, please review the changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol Definition: Added TransferService Proto definitions to support both RDMA and TCP transport protocols.
Decode Side Implementation:
Implemented DecodeRpcServerNew2 to coordinate asynchronous Prefill calls and execute the Decode phase.
Prefill Side Implementation:
Implemented PrefillRpcServerNew2 to handle incoming Prefill requests and manage P2P cache loading.
Client Component:
Introduced PrefillServerCaller to support asynchronous Prefill RPC calls with connection pooling capabilities.
Initialization & API:
Enabled P2PConnector initialization logic.
Exposed the loadCacheSync interface for synchronous cache loading operations.