Improve macOS signing - #975
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes macOS Developer ID signing before SDK packaging.
Changes:
- Signs and verifies the shared native dylib.
- Updates JS addon signing to the Apple ESRP policy.
- Documents signing and deferred notarization.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.pipelines/v2/templates/steps-build-macos.yml |
Adds dylib signing and verification. |
.pipelines/v2/templates/steps-build-js.yml |
Restricts JS signing to .node addons. |
.pipelines/v2/templates/stages-build-native.yml |
Adds ESRP signing variables. |
.pipelines/v2/sdk_v2-pipeline-plan.md |
Documents native signing. |
.pipelines/v2/sdk_v2-js-pipeline-plan.md |
Updates signing ownership and policy. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Baiju Meswani (baijumeswani)
previously approved these changes
Aug 11, 2026
Baiju Meswani (baijumeswani)
previously approved these changes
Aug 11, 2026
Scott McKay (skottmckay)
enabled auto-merge (squash)
August 11, 2026 12:11
Baiju Meswani (baijumeswani)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.