fix(zone.js): patch entire promise in node

alan-agius4 · alan-agius4 · commit 88bb6e8125dd · 2023-06-02T11:02:58.000Z
In angular#49144 we introduced a change to only path `Promise.prototype.then` due to Node.js `SafePromise` complaining about `Promise.prototype.then` called on incompatible receiver. This however introduced a number of regressions. This commit reverts this change and re-introduces the changes to patch the entire promise on Node. The original `SafePromise` problem is no longer reproducible as of Node.js version 18.13+ as it was addressed as part of nodejs/node#45175. While the Angular CLI does not yet generate ESM server bundles, users using ESM with dynamic imports will require using Node.js 18.13 or later. Closes angular#50513, closes angular#50457, closes angular#50414 and closes angular#49930
diff --git a/packages/zone.js/bundles.bzl b/packages/zone.js/bundles.bzl
@@ -14,7 +14,7 @@ BUNDLES_ENTRY_POINTS = {
         "entrypoint": _DIR + "mix/rollup-mix",
     },
     "zone-node": {
-        "entrypoint": _DIR + "node/rollup-main-node-bundle",
+        "entrypoint": _DIR + "node/rollup-main",
     },
     "async-test": {
         "entrypoint": _DIR + "testing/async-testing",
diff --git a/packages/zone.js/lib/node/promise.ts b/packages/zone.js/lib/node/promise.ts
diff --git a/packages/zone.js/lib/node/rollup-main-node-bundle.ts b/packages/zone.js/lib/node/rollup-main-node-bundle.ts
diff --git a/packages/zone.js/lib/node/rollup-test-main.ts b/packages/zone.js/lib/node/rollup-test-main.ts
@@ -6,6 +6,6 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import './rollup-main-node-bundle';
+import './rollup-main';
 // load test related files into bundle
 import '../testing/zone-testing';
diff --git a/packages/zone.js/test/promise/promise-adapter.mjs b/packages/zone.js/test/promise/promise-adapter.mjs
@@ -18,8 +18,4 @@ const rejected = (reason) => {
   return Promise.reject(reason);
 };
 
-process.on('unhandledRejection', (error) => {
-  console.log('unhandled', error);
-});
-
 export default {deferred, resolved, rejected};
diff --git a/packages/zone.js/test/promise/promise-test.mjs b/packages/zone.js/test/promise/promise-test.mjs
@@ -1,7 +1,7 @@
 import promisesAplusTests from 'promises-aplus-tests';
 import adapter from './promise-adapter.mjs';
 
-promisesAplusTests(adapter, {reporter: 'dot', timeout: 500}, function (err) {
+promisesAplusTests(adapter, {reporter: 'dot'}, function (err) {
   if (err) {
     console.error(err);
     process.exit(1);
