Resolving #283 user warning when delay_after_gen is not in use#297
Closed
greenLeopard wants to merge 1 commit intoahmedfgad:masterfrom
Closed
Resolving #283 user warning when delay_after_gen is not in use#297greenLeopard wants to merge 1 commit intoahmedfgad:masterfrom
greenLeopard wants to merge 1 commit intoahmedfgad:masterfrom
Conversation
Owner
|
Thank you but the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made three small changes to remove the UserWarning without suppressing all warnings (#283 ).
delay_after_gento None.self.delay_after_gento None.time.sleep(self.delay_after_gen)just check whether it's None.Although, the alternative, since it's being deprecated, is to remove all references to
delay_after_gen. I'll be happy to do that if it's your preference, then I'll resubmit the PR.