skills/cost-aware-llm-pipeline/SKILL.md (3)

74-75: Consider clarifying budget boundary behavior.

The over_budget property uses > which allows spending exactly the budget limit. If this is intentional, consider adding a docstring or comment to clarify that meeting the budget exactly is acceptable. If you want to prevent reaching the limit, use >= instead.

---

147-147: Consider showing the cost calculation.

While the ellipsis placeholders are acceptable for documentation, it would be helpful to show or reference how to calculate cost_usd from input_tokens and output_tokens using the pricing table. This would make the example more complete and actionable.

Example cost calculation

# Example cost calculation based on pricing table
def calculate_cost(model: str, input_tokens: int, output_tokens: int) -> float:
    """Calculate cost in USD based on model and token counts."""
    pricing = {
        MODEL_HAIKU: (0.80 / 1_000_000, 4.00 / 1_000_000),    # input, output per token
        MODEL_SONNET: (3.00 / 1_000_000, 15.00 / 1_000_000),
    }
    input_rate, output_rate = pricing.get(model, (0, 0))
    return (input_tokens * input_rate) + (output_tokens * output_rate)

# Then in line 147:
record = CostRecord(
    model=model, 
    input_tokens=response.usage.input_tokens,
    output_tokens=response.usage.output_tokens,
    cost_usd=calculate_cost(model, response.usage.input_tokens, response.usage.output_tokens)
)

---

92-102: Move the comment about non-retryable errors into the docstring.

The code after line 100 is unreachable because the function always returns, raises, or propagates an exception within the loop. The comment on line 101 documents important behavior but should be placed in the docstring instead to avoid unreachable code.

The Anthropic SDK error classes (APIConnectionError, RateLimitError, InternalServerError) are correct and properly imported.

♻️ Suggested improvement

 def call_with_retry(func, *, max_retries: int = _MAX_RETRIES):
-    """Retry only on transient errors, fail fast on others."""
+    """Retry only on transient errors, fail fast on others.
+    
+    Non-retryable errors (AuthenticationError, BadRequestError, etc.) 
+    will raise immediately.
+    """
     for attempt in range(max_retries):
         try:
             return func()
         except _RETRYABLE_ERRORS:
             if attempt == max_retries - 1:
                 raise
             time.sleep(2 ** attempt)  # Exponential backoff