android, desktop: constrain image height in layout#6959
Merged
Conversation
Clamp the image preview Box's aspect ratio so it never goes below 1/2.33 (matching the height cap already enforced by PriorityLayout). Prevents tall image previews from overflowing into the caption area below. Analogous to iOS #6732.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tall image previews (
height > 2.33 × width) overlapped the caption — Compose'saspectRatiocouldn't satisfy both.width(W)andPriorityLayout's height cap, fell through to unbounded constraints, and the innerImageoverflowed its layout box. Clamping with.coerceAtLeast(1f / 2.33f)keeps the ratio in the range Compose can satisfy, so the layout stays bounded andclipToBoundscrops the painter cleanly. Analogous to iOS #6732.