Skip to content

fix(eth): fix state hooks in API #30830#2066

Merged
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:fix-api-state-hooks
Feb 17, 2026
Merged

fix(eth): fix state hooks in API #30830#2066
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:fix-api-state-hooks

Conversation

@gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Feb 15, 2026

Proposed changes

Ref: ethereum#30830

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI reviewed Feb 15, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the EVM initialization pattern to fix state hooks in the API. The core change is modifying the vm.NewEVM constructor to no longer accept a TxContext parameter, instead introducing a SetTxContext method to update the transaction context separately. This allows the EVM to be created once per block with a hooked state database and reused across multiple transactions within the same block, ensuring that state change hooks (like OnBalanceChange, OnNonceChange, and OnStorageChange) are properly triggered.

Changes:

  • Refactored vm.NewEVM to accept only block context and state database, removing the transaction context parameter
  • Added evm.SetTxContext() method to update transaction context separately after EVM creation
  • Updated all EVM instantiation sites across the codebase to use the new two-step pattern: create EVM with block context, then call SetTxContext before transaction execution
  • Moved balance setting operations from eth/api_backend.go to internal/ethapi/api.go where they are used

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
core/vm/evm.go Refactored NewEVM signature to remove TxContext parameter; added SetTxContext and SetTracer methods with improved documentation
core/state_processor.go Updated to create EVM once per block with tracingStateDB and reuse it across transactions; simplified ApplyTransaction signature
miner/worker.go Moved EVM creation to Work struct initialization for reuse; removed redundant EVM creation in commitTransaction
internal/ethapi/api.go Moved SetBalance call into applyMessage; updated to call SetTxContext after EVM creation
internal/ethapi/backend.go Simplified GetEVM signature to remove Message parameter; moved balance setting to caller
eth/api_backend.go Removed unused imports; updated GetEVM implementation to match new signature
internal/ethapi/simulate.go Updated to use tracingStateDB pattern and call SetTxContext
eth/tracers/api.go Updated tracing code to properly create hooked state and call SetTxContext
eth/state_accessor.go Refactored to create EVM once and reuse across transactions when replaying block state
eth/gasestimator/gasestimator.go Updated to call SetTxContext after EVM creation
core/vm/runtime/env.go Updated to call SetTxContext after EVM creation
tests/*.go Updated all test files to use new EVM initialization pattern
eth/tracers/*_test.go Updated tracer tests to use new pattern; added TestStateHooks to verify state hooks work correctly
core/state_processor_test.go Added TestApplyTransactionWithEVMStateChangeHooks to verify state hooks are invoked
consensus/tests/*/helper.go Updated helper functions to create EVM with new pattern
accounts/abi/bind/backends/simulated.go Updated simulated backend to use new EVM initialization pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gzliudan gzliudan force-pushed the fix-api-state-hooks branch from 4c0864c to 0ffb353 Compare February 17, 2026 09:11
@AnilChinchawale AnilChinchawale merged commit bba58ec into XinFinOrg:dev-upgrade Feb 17, 2026
9 checks passed
@gzliudan gzliudan deleted the fix-api-state-hooks branch February 17, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@AnilChinchawale AnilChinchawale AnilChinchawale approved these changes

@wanwiset25 wanwiset25 wanwiset25 approved these changes

@benjamin202410 benjamin202410 benjamin202410 approved these changes

@anunay-xin anunay-xin anunay-xin approved these changes

@liam-lai liam-lai Awaiting requested review from liam-lai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gzliudan @AnilChinchawale @wanwiset25 @benjamin202410 @anunay-xin