fix(sv): fix slang RTL export compatibility#82
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the SystemVerilog/Verilog parsing path that uses slang, aiming to make RTL export more compatible with real-world filelist flows (macros shared across files, deterministic file ordering, and tolerating missing child modules).
Changes:
- Add unit tests covering macro visibility across filelist sources, filelist-vs-explicit ordering, and missing child module handling.
- Update slang driver invocation to use single compilation unit mode, ignore unknown modules, and enable VCS compatibility mode when requested.
- Deduplicate explicit/direct source arguments against sources discovered from filelists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/parser/sv.cpp |
Adds slang CLI flags and introduces source deduplication logic using a seen_sources set. |
test/test_parser_sv_unit.cpp |
Adds new regression tests for filelist macro behavior, ordering, and missing child modules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Makiras
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #81