Don't bump Homebrew from the release; the formula is autobumped - #401
Merged
Merged
Conversation
xctesthtmlreport is on Homebrew's autobump list. BrewTestBot opens a version-bump PR against homebrew-core on its own roughly every 3 hours after a release, and brew bump-formula-pr refuses a manual bump for autobumped formulae: Whoops, the xctesthtmlreport formula has its version update pull requests automatically opened by BrewTestBot every ~3 hours! Every formula PR since 2.5.1 was opened by BrewTestBot, and the Brew Bump workflow has zero runs in its history — the formula has been updating without it the whole time. So the homebrew job added in #400 would have failed on every release, turning the release workflow red for a step that is not needed. Removed. The workflow itself is kept as a manual escape hatch for the case where the formula leaves the autobump list, but is no longer wired into the release. Its workflow_call plumbing goes with the caller. This only surfaced once HOMEBREW_BUMP_ACCESS_TOKEN was valid: with an expired token brew failed at authentication before ever reaching the autobump check. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Homebrew bump workflow is now manual-only. Its reusable trigger was removed, and the release workflow no longer invokes it. Documentation describes BrewTestBot autobumping and the manual escape hatch. ChangesHomebrew release workflow decoupling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
homebrewjob added in #400 would have failed on every release. Removing it.What happened
With
HOMEBREW_BUMP_ACCESS_TOKENregenerated, the bump got past authentication and reachedbrew bump-formula-pr, which refused it:xctesthtmlreportis on Homebrew's autobump list.brew bump-formula-prdeliberately rejects manual bumps for autobumped formulae.This was already true
The 2.5.1 formula PR was opened by BrewTestBot ~2.5 hours after the 2.5.1 release, and the
Brew Bumpworkflow has zero runs in its entire history. The formula has been updating on its own the whole time; the workflow never did anything.3.0.0 will reach Homebrew the same way, without intervention.
Change
homebrewjob fromrelease.yml, and theworkflow_callplumbing that existed only to serve it.homebrew-bump.ymlas a manualworkflow_dispatchescape hatch, for the case where the formula later leaves the autobump list (gainsno_autobump!or a skipped livecheck). It is deliberately not wired into the release, since it would fail there.Why it wasn't caught sooner
The expired token masked it: brew failed at authentication before it ever evaluated whether the formula was autobumped. Checking who authors the formula PRs in homebrew-core would have revealed it immediately, and should have been the first thing checked.
🤖 Generated with Claude Code
Summary by CodeRabbit