Updated main -> gui -> source -> main.cpp#2012
Updated main -> gui -> source -> main.cpp#2012Isaadqurashi wants to merge 3 commits intoWerWolv:masterfrom
Conversation
Exception handling was added to catch any runtime errors. Safe handling of the Linux distribution information was implemented to avoid potential crashes when the value is unavailable... Improved logging for the Linux distribution to handle empty versions and missing distro data.
Update main.cpp
|
Thanks for the PR! I'm generally okay with the changes. However, as with the try-catch block in window.cpp, it should be #if-defined out in debug builds as it will make it very annoying to debug uncaught exceptions. Additionally, instead of just logging to the console, it might be nice to display an OS popup using |
|
Thank you for the feedback! Regarding the logging mechanism I agree that displaying an OS popup using However my finals are approaching, so I might need some time to make these adjustments. I'll ensure the changes are pushed as soon as possible after my exams. Please let me know if there's anything else you'd like me to consider in the meantime. |
|
No rush! I'll keep the the PR own until you're done :) Thanks a lot |
2 participants
Exception handling was added to catch any runtime errors.
Safe handling of the Linux distribution information was implemented to avoid potential crashes when the value is unavailable...
Improved logging for the Linux distribution to handle empty versions and missing distro data.