fix: make allowLocalOutbound work on Linux via an explicit localhost port bridge#136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
network.allowLocalOutboundwas silently a no-op on Linux: the sandbox runs underbwrap --unshare-netso its127.0.0.1is a separate loopback from the host's, and nothing bridged them. Fixes #128, by adding a per-port socat bridge from sandbox loopback to host loopback, gated by a newnetwork.allowLocalOutboundPortsallowlist.Per-port (rather than wildcard) because Linux network namespaces need a real forwarder for each port — there's no kernel filter to relax like macOS Seatbelt. A wildcard would require pasta/slirp4netns as a new dependency and is better left to a follow-up. macOS behavior is unchanged (
allowLocalOutboundPortsis Linux-only).Changes
network.allowLocalOutboundPorts []intconfig field with validation, merge dedup, schema, and a sharedEffectiveAllowLocalOutbound()helper.LocalOutboundBridgeininternal/sandbox/linux.gomirroring the reverse-bridge pattern: host-sidesocat UNIX-LISTEN -> TCP:127.0.0.1:<port>, sandbox-sidesocat TCP-LISTEN:127.0.0.1:<port> -> UNIX-CONNECT, with Unix sockets bind-mounted across the namespace boundary.Managerwires the bridge whenallowLocalOutbound=true, ports are listed,--unshare-netis active, and not in wildcard relaxed mode; warns clearly when the boolean is set on Linux without ports.configuration.md,troubleshooting.md,concepts.md, and anARCHITECTURE.mdsection with a diagram symmetric to the reverse-bridge one.