fix: establish parent-child span hierarchy in mock runtimes#76
Merged
cristipufu merged 1 commit intomainfrom Feb 18, 2026
Merged
fix: establish parent-child span hierarchy in mock runtimes#76cristipufu merged 1 commit intomainfrom
cristipufu merged 1 commit intomainfrom
Conversation
Root spans were created with `start_span()` (to avoid async generator context detach errors) but never set as the current context, so all child spans became root-level siblings. Fix by threading explicit `context` parameter via `trace.set_span_in_context()` to all child span calls across all five mock runtimes. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_span()(to avoid async generator context detach errors) were never set as the current context, causing all child spans to be emitted as flat root-level siblings instead of a proper hierarchytrace.set_span_in_context()after creating root/subgraph spans and passing the explicitcontextparameter to all child span callsTest plan
🤖 Generated with Claude Code