feat(AnalyticalTable): add allVisibleRowsSelected to onRowSelect & improve select behavior#8224
Open
feat(AnalyticalTable): add allVisibleRowsSelected to onRowSelect & improve select behavior#8224
allVisibleRowsSelected to onRowSelect & improve select behavior#8224Conversation
|
Size Change: +2.32 kB (+0.51%) Total Size: 460 kB
ℹ️ View Unchanged
|
Pull Request Test Coverage Report for Build 22061834852Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
allVisibleRowsSelectedto theonRowSelectevent detail. When all visible rows in a filtered table (all not filtered-out rows) are selected, this property istrue.onRowSelectevent is fired. Now, the original event is persisted on the mutable table instance and only enriched and fired after the respective table state is finalized.useRowSelectreact-table hookselectionModeis 'None'selectedFlatRowscomputation,isAllRowsSelectedchecks, andprepareRowoverhead when selection is disabledisAllRowsSelectedcomputation is memoized