fix: show correct header in code-hinter for success message field#16377
Open
Rudolph37 wants to merge 1 commit into
Open
fix: show correct header in code-hinter for success message field#16377Rudolph37 wants to merge 1 commit into
Rudolph37 wants to merge 1 commit into
Conversation
Added componentName prop to CodeHinter component to display correct header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Show correct header in code-hinter for success message field
Problem
When opening the code-hinter popup for the "Success Message" field in a RunJS query, the popup header displays "Editor" (default value) instead of "Success Message".
Steps to Reproduce
Expected Behavior
Popup header should display "Success Message".
Root Cause
The
componentNameprop was not passed to the<CodeHinter>component inSuccessNotificationInputs.jsx, causing it to fall back to the default 'Editor' label.Fix
Added
componentName="Success Message"prop to the<CodeHinter>component.Files Changed
frontend/src/AppBuilder/QueryManager/Components/SuccessNotificationInputs.jsxBefore
After